Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix untranslated sections. #3811

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix untranslated sections. #3811

merged 1 commit into from
Nov 21, 2024

Conversation

SherlockShemol
Copy link
Contributor

fix untranslated sections in benchmark/README.md

@volcano-sh-bot
Copy link
Contributor

Welcome @SherlockShemol!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2024
hwdef
hwdef reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Nov 11, 2024
@SherlockShemol SherlockShemol mentioned this pull request Nov 11, 2024
Open
@JesseStutler
Copy link
Member

Please rebase the new master branch because CI has been fixed: #3817

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@SherlockShemol
Copy link
Contributor Author

Please rebase the new master branch because CI has been fixed: #3817

rebased.

hwdef
hwdef reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@Monokaix
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@volcano-sh-bot volcano-sh-bot merged commit 1476ee2 into volcano-sh:master Nov 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

@wangyang0616 wangyang0616 Awaiting requested review from wangyang0616

Assignees

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SherlockShemol @volcano-sh-bot @JesseStutler @Monokaix @hwdef